[Multithreaded] Migrate RunReadyToRunCompiler#55339
Draft
AlesProkop wants to merge 1 commit into
Draft
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to dotnet/msbuild#13073
Context
RunReadyToRunCompilerused process-global state when resolving tool, input, and output paths. The task needs per-project path and process environment handling before it can execute safely as a multithreaded MSBuild task.Changes Made
MSBuildMultiThreadableTaskandIMultiThreadableTasksupport with aTaskEnvironment.Fallbackdefault.TaskEnvironmentwhile preserving original values in diagnostics and compiler arguments.ToolTask.GetProcessStartInfocompatibility override to apply the task-local working directory and environment.Testing
Microsoft.NET.Build.Tasks.csprojfornet11.0successfully.Microsoft.NET.Build.Tasks.csprojfornet472successfully.GivenARunReadyToRunCompilerMultiThreading:RelativePathsResolveIndependentlyForEachTaskverifies relative paths resolve against each task instance's project directory.EmptyToolPathUsesExistingValidationDiagnosticverifies empty paths retain the existing validation failure behavior.